Repository navigation
Move the objective of the 3D house horror below the controls toggle - #1115
Merged
Merged
Conversation
A few games get a rendering test (a gameplay test named "Rendering: ..." taking PNG screenshots): the 3D island (ambient occlusion, depth of field, bloom, tone mapping, terrain, water), the 3D light playground (sun, point and spot lights, shadows), the expanded 3D house horror (models, fog, flashlight, text) and the platformer (2D). scripts/check-rendering-screenshots.js runs only these tests with the latest build of GDevelop and compares the screenshots with the images of rendering-screenshots/ (or writes them with --update). The new rendering-screenshots CI job runs it on main, every night and on the branches changing these games, their images or the scripts: an image that differs while the game did not change is an early warning that the rendering of GDevelop changed. The code running the tests of a game moves to scripts/lib/GameplayTestsRunner.js, to be shared by both scripts, and can now run only some of the tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GFZna1tBkWVDbpAbTNnXpr
The tests of the terrain extension itself (saved data, compatibility with older versions of GDevelop, world scale, brushes of the scene editor...) are removed: the island keeps the tests of the player on the terrain and its rendering test. The rendering tests have no description: it is shown to the users opening the games. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GFZna1tBkWVDbpAbTNnXpr
The texts are drawn with the font settings of the system: on CircleCI, they were drawn a pixel apart from the expected image, while the 3D rendering was the same. The other games show no text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GFZna1tBkWVDbpAbTNnXpr
The objective text was drawn under the toggle between mouse and touch controls, in the top left corner. It is now below it, aligned on its left. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GFZna1tBkWVDbpAbTNnXpr
Contributor
Preview the game(s) changed or added in this Pull RequestThis is an automatic message displaying links to the games in this PR - double check the JSON in case of doubt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Find the key" objective text, in the top left corner, was drawn under the mouse/touch controls toggle. The text now sits below the toggle, aligned on its left edge (from 30;30 to 32;128).
The toggle stays at 32;32, where every starter has it. The gameplay tests of the game pass (7/7), and its rendering screenshot is unchanged (it hides the text layer).
Generated by Claude Code